[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU

Jaroslav Sevcik via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 2 05:11:29 PDT 2019


jarin added inline comments.


================
Comment at: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2
+"""
+Test that expression evaluator can access members of nested classes even if
+the parents of the nested classes were imported from another compilation unit.
----------------
teemperor wrote:
> missing 'the' between 'that' and 'expression evaluator'. Also a missing 'a' between 'of' and 'nested'.
Fixing "the expression evaluator"; "of a nested classes" does not sound right, though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68278/new/

https://reviews.llvm.org/D68278





More information about the lldb-commits mailing list