[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 2 03:06:44 PDT 2019
teemperor added a comment.
Just a few nitpicks about some minor typos, otherwise this LGTM. Thanks for the patch! I assume you need someone to commit this for you?
Comment at: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/TestNestedClassWithParentInAnotherCU.py:2
+Test that expression evaluator can access members of nested classes even if
+the parents of the nested classes were imported from another compilation unit.
missing 'the' between 'that' and 'expression evaluator'. Also a missing 'a' between 'of' and 'nested'.
Comment at: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/main.cpp:11
+ // WrapperB refers to the Inner and Outer DIEs from the other.cpp CU.
+ // It is important that WrapperB is only foward-declared in shared.h.
+ WrapperB* b = foo();
Nit pick: 'foward' -> 'forward'.
CHANGES SINCE LAST ACTION
More information about the lldb-commits