[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Makes sense to me, just delete the custom make_shared stuff.



================
Comment at: lldb/include/lldb/Host/File.h:377-381
+  template <typename... Args>
+  static std::shared_ptr<File> make_shared(Args... args) {
+    return std::static_pointer_cast<File>(
+        std::make_shared<NativeFile>(args...));
+  }
----------------
Please delete this stuff, and just use regular std::make_shared. (BTW, shared_ptr<Derived> is implicitly convertible to shared_ptr<Base>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68317/new/

https://reviews.llvm.org/D68317