[Lldb-commits] [PATCH] D68301: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 2 00:42:52 PDT 2019
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LG, though I'm not sure whether using `using namespace llvm` is such a good idea. There's a fair number of classes with identical names in llvm and lldb_private namespaces. As we start using more of llvm, we will start hitting conflicts. E.g., I've had to handle a bunch of conflicts when I made lldb_private::DataExtractor convertible to llvm::DataExtractor (which made the second name visible nearly everywhere). For this particular case a namespace alias (`namespace json = llvm::json`) might be a better option.
CHANGES SINCE LAST ACTION
More information about the lldb-commits