[Lldb-commits] [PATCH] D67793: new api class: SBFile
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 30 12:17:31 PDT 2019
jingham added a comment.
This looks fine to me, it doesn't look like you are leaving out anything useful.
Note, I think just to enforce the "default constructor" discipline, there's a test in the test suite (python_api/default-constructor/TestDefaultConstructorForAPIObjects.py) that has a file per class that just makes a default constructed object and calls all of its methods to make sure they don't crash. According to that pattern your test_sbfile_invalid test should actually go there.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits