[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 27 10:43:26 PDT 2019

vsk added a subscriber: labath.
vsk added a comment.

Great find. The changes in this patch makes sense to me locally, but I'm having trouble picking up on the context necessary to confidently 'lgtm'. + @JDevlieghere & @labath to get some more experienced people.

I'd love to see the big switch in ParseTypeFromDWARF broken up into small, well-commented functions bit-by-bit -- when that's done, I think I'll have a much better chance at reviewing changes. If folks agree that that's a reasonable refactor, I'd be happy to send a few patches (perhaps starting with the DW_TAG_subroutine_type handling).

Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1401
                       type_handled = cxx_method_decl != NULL;
+                      // Artificial methods are always handled even when don't
+                      // create a new declaration for them.
nit: we don't ?



More information about the lldb-commits mailing list