[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks good to me, but please do give a chance for other to look this over too. Thanks for cleaning this up.

In D67589#1684847 <https://reviews.llvm.org/D67589#1684847>, @jankratochvil wrote:

> | `m_opaque_up` type     | ABI compatible |
> | `llvm::PointerIntPair` | yes (size 8)   |
> |


This is true, but it also inflicts the SB stability requirements onto the `PointerIntPair` class. While I don't imagine the `sizeof(PointerIntPair)` will ever change, I don't think this is a good thing to do, just on principle.



================
Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1
+MAKE_DSYM := NO
+
----------------
I'm pretty sure this line is not needed.


================
Comment at: lldb/source/API/SBCommandReturnObject.cpp:142
 
-  m_opaque_up->Clear();
+  (*this)->Clear();
 }
----------------
I think `get()->Clear()` or `ref().Clear()` would be easier on the eye.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67589/new/

https://reviews.llvm.org/D67589