[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.
Herald added a subscriber: usaxena95.


================
Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:110
     do {
-      DeclVendor *modules_decl_vendor =
-          m_target->GetClangModulesDeclVendor();
+      auto *modules_decl_vendor = llvm::cast<ClangModulesDeclVendor>(
+          m_target->GetClangModulesDeclVendor());
----------------
This part of the change was recently reverted, see: http://llvm.org/viewvc/llvm-project?view=revision&revision=372974

I am wondering if the change right above for `runtime_decl_vendor` is also problematic as well. Can you explain the rationale?

CC @teemperor 




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66451/new/

https://reviews.llvm.org/D66451