[Lldb-commits] [lldb] r372920 - [Dwarf] Fix switch cases that take an dw_tag_t.

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 25 13:59:56 PDT 2019


Author: jdevlieghere
Date: Wed Sep 25 13:59:56 2019
New Revision: 372920

URL: http://llvm.org/viewvc/llvm-project?rev=372920&view=rev
Log:
[Dwarf] Fix switch cases that take an dw_tag_t.

Now that dw_tag_t is an enum, a default case is required.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp?rev=372920&r1=372919&r2=372920&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Wed Sep 25 13:59:56 2019
@@ -3277,6 +3277,8 @@ DWARFASTParser::ParseChildArrayInfo(cons
         array_info.element_orders.push_back(num_elements);
       }
     } break;
+    default:
+      break;
     }
   }
   return array_info;

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=372920&r1=372919&r2=372920&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Wed Sep 25 13:59:56 2019
@@ -314,6 +314,8 @@ void SymbolFileDWARF::GetTypes(const DWA
       case DW_TAG_ptr_to_member_type:
         add_type = (type_mask & eTypeClassMemberPointer) != 0;
         break;
+      default:
+        break;
       }
 
       if (add_type) {
@@ -392,6 +394,8 @@ SymbolFileDWARF::GetParentSymbolContextD
     case DW_TAG_inlined_subroutine:
     case DW_TAG_lexical_block:
       return die;
+    default:
+      break;
     }
   }
   return DWARFDIE();
@@ -3583,6 +3587,8 @@ SymbolFileDWARF::FindBlockContainingSpec
           spec_block_die_offset)
         return die;
     } break;
+    default:
+      break;
     }
 
     // Give the concrete function die specified by "func_die_offset", find the

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp?rev=372920&r1=372919&r2=372920&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp Wed Sep 25 13:59:56 2019
@@ -55,6 +55,8 @@ bool UniqueDWARFASTTypeList::Find(const
               case DW_TAG_partial_unit:
                 done = true;
                 break;
+              default:
+                break;
               }
             }
             parent_arg_die = parent_arg_die.GetParent();




More information about the lldb-commits mailing list