[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 3 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/lit/Suite/lldbtest.py:105
 
+        has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
+        has_passing_tests = 'PASS:' in out or 'PASS:' in err
----------------
aprantl wrote:
> JDevlieghere wrote:
> > aprantl wrote:
> > > `'UNSUPPORTED:' in out + err` ?
> > Is that actually faster? If not I'd like to keep things consistent with the rest of the code above and below it. 
> I was optimizing for readability, not speed :-)
> The principled solution would be to emit the same kind of junit XML output that lit produces or some other machine-readable format.
I agree. It's on my todo list :-) 


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68039/new/

https://reviews.llvm.org/D68039