[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 25 11:19:37 PDT 2019


JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/lit/Suite/lldbtest.py:105
 
+        has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
+        has_passing_tests = 'PASS:' in out or 'PASS:' in err
----------------
aprantl wrote:
> `'UNSUPPORTED:' in out + err` ?
Is that actually faster? If not I'd like to keep things consistent with the rest of the code above and below it. 


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68039/new/

https://reviews.llvm.org/D68039





More information about the lldb-commits mailing list