[Lldb-commits] [PATCH] D68039: [lit] Do a better job at parsing unsupported tests.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 25 11:06:58 PDT 2019

JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, labath, jingham, xiaobai.
Herald added a project: LLDB.

When all the tests run by dotest are unsupported, it still reports `RESULT: PASSED` which we translate to success for lit. We can better report the status as unsupported when we see that there are unsupported tests but no passing tests. This will not affect the situation where there are failures or unexpected passes, because those report a non-zero exit code.




Index: lldb/lit/Suite/lldbtest.py
--- lldb/lit/Suite/lldbtest.py
+++ lldb/lit/Suite/lldbtest.py
@@ -102,6 +102,11 @@
             if 'XPASS:' in out or 'XPASS:' in err:
                 return lit.Test.XPASS, out + err
+        has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
+        has_passing_tests = 'PASS:' in out or 'PASS:' in err
+        if has_unsupported_tests and not has_passing_tests:
+            return lit.Test.UNSUPPORTED, out + err
         passing_test_line = 'RESULT: PASSED'
         if passing_test_line not in out and passing_test_line not in err:
             msg = ('Unable to find %r in dotest output (exit code %d):\n\n%s%s'

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68039.221806.patch
Type: text/x-patch
Size: 748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190925/190349e9/attachment.bin>

More information about the lldb-commits mailing list