[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:513
+            debugserver_version[0], debugserver_version[1],
+            actual_debugserver_version) else None
+    return skipTestIfFn(is_older_out_of_tree_debugserver)
----------------
IMHO the expression if-else is only good for readability if the expression fits on one line :-)


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyCrash.py:18
     @expectedFailureNetBSD
-    @skipIfOutOfTreeDebugserver
+    @skipIfOutOfTreeDebugserver(['<=', '9999'])
     def test(self):
----------------
Did you file a radar to update these tests once the version number is known?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68003/new/

https://reviews.llvm.org/D68003