[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 25 09:42:32 PDT 2019
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py:18
+ @skipIfOutOfTreeDebugserver(['<=', '9999'])
> JDevlieghere wrote:
> > I used 9999 here because that's commonly the placeholder until the next release.
> I haven't looked at the code in detail, but given that you are removing the explicit notion of an "out of tree" debug server, it seems to be that this will kick in even if you are testing against the in-tree debug server, which doesn't seem right. Or am I missing something?
Yeah, I was just going to check for version numbers below a hundred, but then forgot to add it before I uploaded the patch.
CHANGES SINCE LAST ACTION
More information about the lldb-commits