[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/trunk/include/lldb/Core/dwarf.h:23
 typedef int32_t dw_sleb128_t;
 typedef uint16_t dw_attr_t;
 typedef uint16_t dw_form_t;
----------------
so should this be `llvm::dwarf::Attribute`?


================
Comment at: lldb/trunk/include/lldb/Core/dwarf.h:24
 typedef uint16_t dw_attr_t;
 typedef uint16_t dw_form_t;
+typedef llvm::dwarf::Tag dw_tag_t;
----------------
`llvm::dwarf::Form`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68005/new/

https://reviews.llvm.org/D68005