[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 25 02:37:05 PDT 2019
labath accepted this revision.
labath added a comment.
Yay, tons of nasty python code going down the drain. This looks fine, but please take it slowly when landing these patches. Waiting a day or two before proceeding with the next patch will make it easier to fix things up if any of them cause problems for some people.
In D68007#1681908 <https://reviews.llvm.org/D68007#1681908>, @mgorny wrote:
> Thanks! That's a great job, and certainly saves me some trouble in pushing my patch forward, though I'm kinda surprised we don't need site-packages path there after all.
I guess that's because this script puts its output in a temporary location, and the "finish" script then copies it to the site-packages folder. I think this was mainly done because we were doing some post-processing of the swig-generated code, which we don't do any more thankfully, so it may be possible to have this put the code straight into the final location, but it's better to take things one slowly.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits