[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

[Alex Langford via Phabricator via lldb-commits]

xiaobai added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3029
   Log *log = LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO);
-  TypeSP type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr);
+    
+  TypeSP type_sp;
----------------
nit: stray whitespace


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3032
+    
+     type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr);
   if (type_sp) {
----------------
Why is this now two lines?


================
Comment at: tools/lldb-test/lldb-test.cpp:580
+    }
 
   return Error::success();
----------------
nit: clang-format this block, some of the lines are long and somewhat difficult to read on phabricator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67994/new/

https://reviews.llvm.org/D67994