[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

A few things that need checking/reordering, but otherwise great cleanup!



================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/Makefile:4
 include Makefile.rules
-CXXFLAGS += -O0
+CXXFLAGS_EXTRAS := -O0
 
----------------
This is wrong ;-) This should probably just go away.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vector/Makefile:4
 USE_LIBCPP := 1
 include Makefile.rules
+CXXFLAGS_EXTRAS := -O0
----------------
Same here


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/Makefile:3
 CXX_SOURCES := main.cpp
 include $(LEVEL)/Makefile.rules
+CXXFLAGS_EXTRAS := -O1 -glldb -Xclang -femit-debug-entry-values
----------------
Another one


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/ambiguous_tail_call_seq1/Makefile:3
 include Makefile.rules
-CXXFLAGS += -g -O1 -glldb
+CXXFLAGS_EXTRAS := -g -O1 -glldb
----------------
These one too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67984/new/

https://reviews.llvm.org/D67984