[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

Tue Sep 24 14:03:32 PDT 2019

aprantl created this revision.
aprantl added reviewers: jasonmolenda, JDevlieghere, labath.
Herald added subscribers: arphaman, christof.

This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides and updates of variables like CFLAGS with safe assignments to variables reserved for this purpose like CFLAGS_EXTRAS.

https://reviews.llvm.org/D67984

Files:
  lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile
  lldb/packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/call-throws/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/context-object-objc/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/import_builtin_fileid/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/namespace_local_var_same_name_obj_c/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/persist_objc_pointeetype/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/po_verbosity/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/scoped_enums/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/two-files/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/Makefile
  lldb/packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile
  lldb/packages/Python/lldbsuite/test/commands/frame/var/Makefile
  lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/Makefile
  lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_bound_violation/Makefile
  lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_by_line_and_column/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_ids/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/consecutive_breakpoints/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/dummy_target_breakpoints/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/objc/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/require_hw_breakpoints/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/boolreference/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/compactvectors/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/nsindexpath/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/nsstring/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-proper-plurals/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/loop/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/map/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multimap/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multiset/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/set/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vector/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vbool/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/nsarraysynth/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/nsdictionarysynth/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/nssetsynth/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/ostypeformatting/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/poarray/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/ptr_ref_typedef/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/synthupdate/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/inferior-crashing/recursive-inferior/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/inline-stepping/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/mtc/simple/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/set-data/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/ambiguous_tail_call_seq1/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/ambiguous_tail_call_seq2/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/disambiguate_call_site/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/disambiguate_tail_call_seq/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/inlining_and_tail_calls/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_message/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/unambiguous_sequence/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_all/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/Makefile
  lldb/packages/Python/lldbsuite/test/functionalities/type_lookup/Makefile
  lldb/packages/Python/lldbsuite/test/lang/c/blocks/Makefile
  lldb/packages/Python/lldbsuite/test/lang/c/const_variables/Makefile
  lldb/packages/Python/lldbsuite/test/lang/c/local_variables/Makefile
  lldb/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile
  lldb/packages/Python/lldbsuite/test/lang/c/unicode/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/breakpoint_in_member_func_w_non_primitive_params/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/enum_types/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/limit-debug-info/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/modules-import/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/rvalue-references/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/blocks/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/forward-decl/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/foundation/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/global_ptrs/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/ivar-IMP/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-incomplete/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/modules/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-checker/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-class-method/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-dynamic-value/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-ivar-offsets/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-ivar-stripped/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-new-syntax/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-optimized/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-property/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-runtime-ivars/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-static-method-stripped/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-static-method/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-stepping/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-struct-argument/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-struct-return/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/objc-super/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/orderedset/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/print-obj/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/radar-9691614/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/rdar-10967107/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/rdar-11355592/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/real-definition/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/sample/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objc/single-entry-dictionary/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/Makefile
  lldb/packages/Python/lldbsuite/test/lang/objcxx/sample/Makefile
  lldb/packages/Python/lldbsuite/test/linux/add-symbols/Makefile
  lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile
  lldb/packages/Python/lldbsuite/test/macosx/order/Makefile
  lldb/packages/Python/lldbsuite/test/make/Makefile.rules
  lldb/packages/Python/lldbsuite/test/python_api/findvalue_duplist/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/formatters/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/frame/inlines/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/lldbutil/iter/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/lldbutil/process/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/module_section/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/objc_type/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/value_var_update/Makefile
  lldb/packages/Python/lldbsuite/test/sample_test/Makefile
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/Makefile
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/inferior-crash/Makefile

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67984.221589.patch
Type: text/x-patch
Size: 73698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190924/690858dd/attachment-0001.bin>