[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This looks mostly fine to me. There's still a lot more copy-pasta between the three kinds of register contexts than I'd like (e.g. on linux, all of these three cases are handled by a single class), but I don't have a clear idea what to do about that at this point.



================
Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:447-449
+        std::ostringstream ostr;
+        ostr << reg_ctx.GetWatchpointAddress(wp_id) << " " << wp_id << " "
+             << reg_ctx.GetWatchpointHitAddress(wp_id);
----------------
Though the std::stringstream classes are used in a couple of places, we usually try to stay away from all std::stream classes. In this case, I'd just do a `llvm::formatv(...).str()`


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67222/new/

https://reviews.llvm.org/D67222