[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

Tue Sep 24 02:00:45 PDT 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This is definitely right. I remember running into this in the past, but I don't remember whether I ended up not committing the fix, or is this another instance of that bug.

In either case, it's sad that there are no tests breaking due to this. Ideally we'd have a small arm64 macho core file with well known register values that we could just assert are read correctly. You probably don't have the means to create such a core file, so it's not fair to ask you to do that, but it would be great if one of the apple folks added a test like that.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67892/new/

https://reviews.llvm.org/D67892