[Lldb-commits] [PATCH] D67903: [lldb] Add completion support for log enable/disable/list

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked an inline comment as done.
teemperor added inline comments.


================
Comment at: lldb/source/Utility/Log.cpp:49
+
+void Log::ListCategories(llvm::raw_ostream &stream,
+                         const ChannelMap::value_type &entry) {
----------------
JDevlieghere wrote:
> Is this used outside of CommandObjectLog? Otherwise this should probably go there.
Yeah I think both the channel and category functions are only used once by CommandObjectLog. Will clean that up in a separate NFC commit.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67903/new/

https://reviews.llvm.org/D67903