[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

Haibo Huang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 23 15:38:37 PDT 2019


hhb accepted this revision.
hhb added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39
 #endif
+#ifndef S_IRGRP
 #define S_IRGRP 0 /* read, group */
----------------
Maybe move these into the defined(_MSC_VER) above? Or the other way? Seems they should be consistent.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67910/new/

https://reviews.llvm.org/D67910





More information about the lldb-commits mailing list