[Lldb-commits] [lldb] r372656 - [LLDB] Rework a MinGW build fix from D65691

Martin Storsjo via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 23 13:43:11 PDT 2019

Author: mstorsjo
Date: Mon Sep 23 13:43:11 2019
New Revision: 372656

URL: http://llvm.org/viewvc/llvm-project?rev=372656&view=rev
[LLDB] Rework a MinGW build fix from D65691

That change didn't contain any explanation for this bit. There shouldn't
be any need for a check for MinGW ifdefs here, as long as the include
uses lowercase windows.h (as is used consistently elsewhere in
the llvm projects).

Differential Revision: https://reviews.llvm.org/D67894


Modified: lldb/trunk/tools/lldb-vscode/VSCode.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/VSCode.cpp?rev=372656&r1=372655&r2=372656&view=diff
--- lldb/trunk/tools/lldb-vscode/VSCode.cpp (original)
+++ lldb/trunk/tools/lldb-vscode/VSCode.cpp Mon Sep 23 13:43:11 2019
@@ -15,10 +15,8 @@
 #include "llvm/Support/FormatVariadic.h"
 #if defined(_WIN32)
-#ifndef __MINGW32__
 #define NOMINMAX
-#include <Windows.h>
-#endif // __MINGW32__
+#include <windows.h>
 #include <fcntl.h>
 #include <io.h>

More information about the lldb-commits mailing list