[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd added a comment.

I think that `printf` is quite an amazing notification :-)



================
Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:87
   case 4:
 #if defined(__x86_64__) || defined(_M_AMD64)
   case 8:
----------------
mstorsjo wrote:
> compnerd wrote:
> > Should this line not also include `|| defined(__aarch64__) || defined(_M_ARM64)`?
> I guess it should. Or this might be one of the few places where checking for just `_WIN64` might be easiest?
Yeah, I think that `_WIN64` is probably the easiest thing indeed.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67911/new/

https://reviews.llvm.org/D67911