[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna added a comment.

In D67891#1678933 <https://reviews.llvm.org/D67891#1678933>, @labath wrote:

> ....The first option would require making the File class movable....


I don't think making File movable will work.   I'll be wanting a PythonFile subclass, which overrides virtual methods in File.   It won't be possible to move one of those into a File variable.     I do think the second option, with unique_ptr does make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67891/new/

https://reviews.llvm.org/D67891