[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 23 10:21:12 PDT 2019
mgorny added a reviewer: ZeGentzy.
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at: lldb/scripts/get_relative_lib_dir.py:26
split_libdir = arch_specific_libdir.split(os.sep)
- lib_re = re.compile(r"^lib.+$")
+ lib_re = re.compile(r"^lib.*$")
> If we go this way, should we always use LLDB_PYTHON_RELATIVE_LIBDIR in ScriptInterpreterPython.cpp, and add some code to make sure it is defined? Because all assumption of the path can be wrong.
> After the change here, I think POSIX will always use LLDB_PYTHON_RELATIVE_LIBDIR. But for windows, the path is still hard coded to lib/site-packages.
> (maybe finishSwigPythonLLDB.py / make_symlink() can also be updated to use os.path.relpath? )
Actually, I think we can kill all this logic by simply passing `''` as prefix, as I did in the CMake part.
CHANGES SINCE LAST ACTION
More information about the lldb-commits