[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

Mon Sep 23 10:21:10 PDT 2019

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:233
+          case llvm::Triple::EnvironmentType::Simulator:
+          case llvm::Triple::EnvironmentType::UnknownEnvironment:
+          case llvm::Triple::EnvironmentType::MacABI:
----------------
Can you add a comment here that this is to support older compilers that don't support the -simulator environment yet?

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67869/new/

https://reviews.llvm.org/D67869