[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 23 07:04:36 PDT 2019
jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.
In D67915#1679030 <https://reviews.llvm.org/D67915#1679030>, @kwk wrote:
> @jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h
I expected some archeology like: D16004 <https://reviews.llvm.org/D16004> added `operator==()` where `e_num` was already a constant. `e_num` was added in D9471 <https://reviews.llvm.org/D9471> and it was also a constant there.
So yes, the fix is OK.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits