[Lldb-commits] [PATCH] D67793: new api class: SBFile

Mon Sep 23 05:58:52 PDT 2019

labath added a comment.

In D67793#1678259 <https://reviews.llvm.org/D67793#1678259>, @lawrence_danna wrote:

> @labath
>
> I wrote a patch for the shared_ptr approach.   It's simple, but it touches a lot of lines.
>
> https://reviews.llvm.org/D67891
>
> Now that I've gone and done it, I kind of like it better that way.   If you approve the other patch, I'll update this one accordingly.

Thanks for the quick turnaround. /I think/ the approach in the other patch looks better (I am super happy about the removal of the SetXXX methods), but I'd still like to understand whether we need to introduce that many shared_ptrs, so I'll need to think about this some more (I just got back from vacation and I am still working through my backlog).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67793/new/

https://reviews.llvm.org/D67793