[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

Mon Sep 23 04:25:38 PDT 2019

mstorsjo added a comment.

In D67885#1678701 <https://reviews.llvm.org/D67885#1678701>, @MyDeveloperDay wrote:

> Just as a drive by comment, there is code in  DebugInfo/Symbolize/Symbolize.cpp that loads dbghelp via #pragma comment(lib... trick

Yes, but as I mentioned in the patch description here, #pragma comment(lib) only works in MSVC mode, it isn't supported when targeting MinGW unless -fms-extensions is specified (and if building with GCC and/or linking with GNU ld, it's not supported at all).

> There is also code to load dbghelp dynamically in lib\Support\Windows\Signal.inc including loading MiniDumpWriteDump

I guess that could be an option as well, for a slightly larger change instead.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67885/new/

https://reviews.llvm.org/D67885