[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

Martin Storsjö via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 23 03:23:19 PDT 2019


mstorsjo updated this revision to Diff 221276.
mstorsjo retitled this revision from "[LLDB] Check for the __MINGW32__ define instead of __MINGW64" to "[LLDB] Remove a now redundant windows specific workaround".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Updated the patch to simply remove the now redundant workaround.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67861/new/

https://reviews.llvm.org/D67861

Files:
  lldb/source/Host/windows/Windows.cpp


Index: lldb/source/Host/windows/Windows.cpp
===================================================================
--- lldb/source/Host/windows/Windows.cpp
+++ lldb/source/Host/windows/Windows.cpp
@@ -48,13 +48,8 @@
   size_t buflen;
   va_list ap2;
 
-#if defined(_MSC_VER) || defined(__MINGW64)
-  ap2 = ap;
-  len = _vscprintf(fmt, ap2);
-#else
   va_copy(ap2, ap);
   len = vsnprintf(NULL, 0, fmt, ap2);
-#endif
 
   if (len >= 0 &&
       (buf = (char *)malloc((buflen = (size_t)(len + 1)))) != NULL) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67861.221276.patch
Type: text/x-patch
Size: 505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190923/4bc6ebb9/attachment.bin>


More information about the lldb-commits mailing list