[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

LGTM. It might be nice to add a comment that this is for saving of minidump files (I assume that's the only reason). The reason for that is the object file plugins are generally expected to work on any host, and so linking os-specific libraries is a bit surprising. Given that lldb is slowly growing support for minidump files on non-windows platforms, it is a matter of time when we will create an os-independent minidump writer (a lot of the pieces are already there), and then this bit of code can be removed.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67885/new/

https://reviews.llvm.org/D67885