[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Thanks for adding the test. LGTM, modulo some nits inline.



================
Comment at: lldb/unittests/Host/CMakeLists.txt:14
   TaskPoolTest.cpp
+  FileTest.cpp
 )
----------------
Please keep the list sorted.


================
Comment at: lldb/unittests/Host/FileTest.cpp:29-32
+  EXPECT_GE(fd, 0);
+
+  FILE *stream = fdopen(fd, "r");
+  EXPECT_TRUE(stream);
----------------
nit: change EXPECT_XXX to ASSERT_XXX as it does not make sense to continue the test if the assertions are not true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67789/new/

https://reviews.llvm.org/D67789