[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: hhb.
Herald added subscribers: JDevlieghere, abidh.
Herald added a project: LLDB.

That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here, as long as the include uses lowercase windows.h (as is used consistently elsewhere in the llvm projects).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D67894

Files:
  lldb/tools/lldb-vscode/VSCode.cpp


Index: lldb/tools/lldb-vscode/VSCode.cpp
===================================================================
--- lldb/tools/lldb-vscode/VSCode.cpp
+++ lldb/tools/lldb-vscode/VSCode.cpp
@@ -15,10 +15,8 @@
 #include "llvm/Support/FormatVariadic.h"
 
 #if defined(_WIN32)
-#ifndef __MINGW32__
 #define NOMINMAX
-#include <Windows.h>
-#endif // __MINGW32__
+#include <windows.h>
 #include <fcntl.h>
 #include <io.h>
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67894.221225.patch
Type: text/x-patch
Size: 420 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190922/6ec083f1/attachment.bin>