[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

Saleem Abdulrasool via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 20 14:36:04 PDT 2019


compnerd added inline comments.


================
Comment at: lldb/source/Host/common/Socket.cpp:479
   }
-  NativeSocket fd = llvm::sys::RetryAfterSignal(-1, ::accept4,
+  NativeSocket fd = llvm::sys::RetryAfterSignal((NativeSocket) -1, ::accept4,
       sockfd, addr, addrlen, flags);
----------------
Could you use C++ style casts please?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67863/new/

https://reviews.llvm.org/D67863





More information about the lldb-commits mailing list