[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo created this revision.
mstorsjo added reviewers: lanza, hhb, labath.
Herald added subscribers: JDevlieghere, abidh.
Herald added a project: LLDB.

This fixes MinGW builds, that otherwise fail due to use of undeclared `GetLastError()` and `ERROR_OPERATION_ABORTED`.

The use of `GetLastError()` was added in SVN r366520 (within an `#ifdef _WIN32`), while the existing include of `lldb/Host/windows/windows.h` was within `#ifdef _MSC_VER`. Change the include ifdef to `#ifdef _WIN32`.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D67857

Files:
  lldb/source/Core/IOHandler.cpp


Index: lldb/source/Core/IOHandler.cpp
===================================================================
--- lldb/source/Core/IOHandler.cpp
+++ lldb/source/Core/IOHandler.cpp
@@ -52,7 +52,7 @@
 
 #include "llvm/ADT/StringRef.h"
 
-#ifdef _MSC_VER
+#ifdef _WIN32
 #include "lldb/Host/windows/windows.h"
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67857.221099.patch
Type: text/x-patch
Size: 313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190920/2d33a7d9/attachment.bin>