[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 20 10:57:08 PDT 2019
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Do we still need `SetOptions` after this? Are there cases where the value needs to change after construction? If not I would consider removing that function. Otherwise this LGTM if Pavel doesn't have any other concerns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67792/new/
https://reviews.llvm.org/D67792
More information about the lldb-commits
mailing list