[Lldb-commits] [PATCH] D67583: Fix swig python package path

[Haibo Huang via Phabricator via lldb-commits]

hhb added a comment.

I don't have the right environment to try your command. But I didn't see anything obviously problematic.

Can you try the following:

  cd /src/llvm-project/lldb/scripts/Python

Then run the following python program:

  import sys
  sys.path.append('/src/llvm-project/lldb/scripts/Python')
  import finishSwigPythonLLDB
  vDictArgs = {"--srcRoot": "/src/llvm-project/lldb",
               "--targetDir": "/src/out/./lib32",
               "--cfgBldDir": "/src/out/tools/lldb/scripts",
               "--prefix": "/src/out",
               "--cmakeBuildConfiguration": ".",
               "--lldbLibDir": "lib32",
               "-m": None,
  }
  finishSwigPythonLLDB.get_framework_python_dir(vDictArgs)

For me the output is:

  (True, '/src/out/./lib/python2.7/site-packages/lldb', '')

Notice that the lib part don't have 32 prefix, even we specified that in parameters.

I kind of feeling that we should change this script to simply return targetDir. There's no good reason to use get_python_lib() and depends on python's implementation. But I don't know enough to make this decision...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67583/new/

https://reviews.llvm.org/D67583