[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/main.cpp:18
+    result = subcommand(dbg, "help");
+    result = result;
+    if (!result.Succeeded())
----------------
jankratochvil wrote:
> labath wrote:
> > Is that intentional? If so, why?
> It has no purpose there for this bugfix but when already writing a testcase I wanted to test this generally fragile functionality.
> 
If you mean the line:
```
+     if (!result.Succeeded())
```
That is not really needed for this testcase but I think this is how a real world implementation should behave so why not here, just 2 lines of code.



Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67589/new/

https://reviews.llvm.org/D67589