[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D67641#1671917 <https://reviews.llvm.org/D67641#1671917>, @hhb wrote:

> In D67641#1671881 <https://reviews.llvm.org/D67641#1671881>, @JDevlieghere wrote:
>
> > Can we match what `FindPythonInterp ` and `FindPythonLibs` does?
> >
> >   mark_as_advanced(
> >     PYTHON_EXECUTABLE
> >     PYTHON_DEBUG_LIBRARY
> >     PYTHON_LIBRARY
> >     PYTHON_INCLUDE_DIR
> >   )
> >
>
>
> Added for PYTHON_EXECUTABLE.
>
> PYTHON_HOME is required, and other variables are derived from PYTHON_HOME. I don't think anyone will be interested in setting them separately...


With `mark_as_advanced` you don't have to modify the code above. Even if they're not needed, I'd still prefer to include the other variables as well, just to maintain consistency with was CMake does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67641/new/

https://reviews.llvm.org/D67641