[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D67390#1671463 <https://reviews.llvm.org/D67390#1671463>, @kwk wrote:

> @clayborg what address is it exactly to store here `std::map<lldb::addr_t, ContString> SymbolMapType;`? As an example `dc_symbol.GetAddress().GetFileAddress()` is something that would work but as soon as we have minidebuginfo, then we might end having the same symbol coming from two different object files and so their address would still be different. Also do you want me to keep this map in `ObjectFileELF`?


We might need a private function on ObjectFileELF that takes an extra parameter. My idea would be something like:

  ... ObjectFileELF::GetSymtab() {
    std::map<lldb::addr_t, ConstString SymbolMapType;
    SymbolMapType symbol_map;
    ParseSymbolTablePrivate(..., symbol_map); // .symtab
    ParseSymbolTablePrivate(..., symbol_map); // .dynsym
    ParseSymbolTablePrivate(..., symbol_map); // .other?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67390/new/

https://reviews.llvm.org/D67390