[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 5 14:34:59 PDT 2019


xiaobai created this revision.
xiaobai added reviewers: clayborg, JDevlieghere, jingham.
Herald added a project: LLDB.

DumpDataExtractor uses ClangASTContext in order to get the proper llvm
fltSemantics for the type it needs so that it can dump floats in a more
precise way. However, there's no reason that this behavior needs to be
specific ClangASTContext. Instead, I think it makes sense to ask
TypeSystems for the float semantics for a type of a given size.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67239

Files:
  lldb/include/lldb/Symbol/ClangASTContext.h
  lldb/include/lldb/Symbol/TypeSystem.h
  lldb/source/Core/DumpDataExtractor.cpp
  lldb/source/Symbol/ClangASTContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67239.218985.patch
Type: text/x-patch
Size: 7178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190905/b3daaca9/attachment.bin>


More information about the lldb-commits mailing list