[Lldb-commits] [PATCH] D67173: [dotest] Centralize initialization commands even more

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:709
+        if lldbtest_config.inferior_env:
+            commands.append('settings set target.env-vars ' +
+                    lldbtest_config.inferior_env)
----------------
JDevlieghere wrote:
> I'm curious why you changed this to use `+` instead of `format`? 
In that moment, it seemed better to me because it is shorter, so I did it as a drive-by. Though now, it's not clear to me that it is really an improvement. I'll just put that back...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67173/new/

https://reviews.llvm.org/D67173