[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance
Guilherme Andrade via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 4 13:37:26 PDT 2019
guiandrade added inline comments.
================
Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:27
// defining here, causing this test to fail, feel free to delete it.
-TEST(DWARFASTParserClangTests,
- TestGetDIEForDeclContextReturnsOnlyMatchingEntries) {
- ClangASTContext ast_ctx;
- DWARFASTParserClangStub ast_parser(ast_ctx);
-
- DWARFUnit *unit = nullptr;
- DWARFDIE die1(unit, (DWARFDebugInfoEntry *)1LL);
- DWARFDIE die2(unit, (DWARFDebugInfoEntry *)2LL);
- DWARFDIE die3(unit, (DWARFDebugInfoEntry *)3LL);
- DWARFDIE die4(unit, (DWARFDebugInfoEntry *)4LL);
- ast_parser.LinkDeclContextToDIE((clang::DeclContext *)1LL, die1);
- ast_parser.LinkDeclContextToDIE((clang::DeclContext *)2LL, die2);
- ast_parser.LinkDeclContextToDIE((clang::DeclContext *)2LL, die3);
- ast_parser.LinkDeclContextToDIE((clang::DeclContext *)3LL, die4);
-
- auto die_list = ast_parser.GetDIEForDeclContext(
- CompilerDeclContext(nullptr, (clang::DeclContext *)2LL));
- ASSERT_EQ(2u, die_list.size());
- ASSERT_EQ(die2, die_list[0]);
- ASSERT_EQ(die3, die_list[1]);
-}
+// TEST(DWARFASTParserClangTests,
+// TestForEachDIEInDeclContextReturnsOnlyMatchingEntries) {
----------------
Once we agree on how to move forward, the idea is to delete/modify this, not leave it commented out
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67022/new/
https://reviews.llvm.org/D67022
More information about the lldb-commits
mailing list