[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

Wed Sep 4 00:25:23 PDT 2019

labath marked an inline comment as done.
labath added inline comments.

================
Comment at: packages/Python/lldbsuite/test/lldbinline.py:116

-        makefile.write("include $(LEVEL)/Makefile.rules\n")
+        makefile.write("include Makefile.rules\n")
         makefile.write("\ncleanup:\n\trm -f Makefile *.d\n\n")
----------------
aprantl wrote:
> labath wrote:
> > aprantl wrote:
> > > wait.. lldbinline can auto-generate a Makefile? Is that feature used by any tests?
> > I would guess "all of them", because otherwise, how would the inline test executable get built?
> I see. My only exposure to inline test was in the Swift branch and there they all ship their own Makefile, but that is likely because they need to set SWIFT_SOURCES instead of the default CXX_SOURCES.
Aha, interesting. I did some stats, and it seems that (in the lldb repo), most (41) inline tests don't come with a Makefile, but there are some (14) that do. I am going to separately check if those 14 can be removed too.

It sounds like it might be interesting to make swift inline tests auto generate makefiles too, but that's up to you guys...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67083/new/

https://reviews.llvm.org/D67083