[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance
Guilherme Andrade via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 3 19:20:30 PDT 2019
guiandrade added inline comments.
================
Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:48
ASSERT_EQ(2u, die_list.size());
- ASSERT_EQ(die2, die_list[0]);
- ASSERT_EQ(die3, die_list[1]);
+ ASSERT_NE(die_list.end(), std::find(die_list.begin(), die_list.end(), die2));
+ ASSERT_NE(die_list.end(), std::find(die_list.begin(), die_list.end(), die3));
----------------
I think we should not expect any particular order, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67022/new/
https://reviews.llvm.org/D67022
More information about the lldb-commits
mailing list