[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: packages/Python/lldbsuite/test/lldbinline.py:116
 
-        makefile.write("include $(LEVEL)/Makefile.rules\n")
+        makefile.write("include Makefile.rules\n")
         makefile.write("\ncleanup:\n\trm -f Makefile *.d\n\n")
----------------
labath wrote:
> aprantl wrote:
> > wait.. lldbinline can auto-generate a Makefile? Is that feature used by any tests?
> I would guess "all of them", because otherwise, how would the inline test executable get built?
I see. My only exposure to inline test was in the Swift branch and there they all ship their own Makefile, but that is likely because they need to set SWIFT_SOURCES instead of the default CXX_SOURCES.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67083/new/

https://reviews.llvm.org/D67083