[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

Mon Sep 2 10:44:01 PDT 2019

labath created this revision.
labath added reviewers: teemperor, aprantl.
Herald added subscribers: arphaman, christof, arichardson, javed.absar, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: jfb.

Instead of each test case knowing its depth relative to the test root,
we can just have dotest add the folder containing Makefile.rules to the
include path.

This was motivated by r370616, though I have been wanting to do this
ever since we moved to building tests out-of-tree.

The only manually modified files in this patch are lldbinline.py and
plugins/builder_base.py. The rest of the patch has been produced by this
shell command:

  find . \( -name Makefile -o -name '*.mk' \)  -exec sed --in-place -e '/LEVEL *:\?=/d' -e '1,2{/^$/d}' -e 's,\$(LEVEL)/,,' {} +

https://reviews.llvm.org/D67083

Files:
  packages/Python/lldbsuite/test/Makefile
  packages/Python/lldbsuite/test/android/platform/Makefile
  packages/Python/lldbsuite/test/api/check_public_api_headers/Makefile
  packages/Python/lldbsuite/test/api/listeners/Makefile
  packages/Python/lldbsuite/test/api/multiple-debuggers/Makefile
  packages/Python/lldbsuite/test/api/multiple-targets/Makefile
  packages/Python/lldbsuite/test/api/multithreaded/Makefile
  packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile
  packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/Makefile
  packages/Python/lldbsuite/test/benchmarks/continue/Makefile
  packages/Python/lldbsuite/test/benchmarks/expression/Makefile
  packages/Python/lldbsuite/test/benchmarks/libcxxlist/Makefile
  packages/Python/lldbsuite/test/benchmarks/libcxxmap/Makefile
  packages/Python/lldbsuite/test/commands/add-dsym/uuid/Makefile
  packages/Python/lldbsuite/test/commands/apropos/with-process/Makefile
  packages/Python/lldbsuite/test/commands/breakpoint/basic/Makefile
  packages/Python/lldbsuite/test/commands/command/nested_alias/Makefile
  packages/Python/lldbsuite/test/commands/command/script/Makefile
  packages/Python/lldbsuite/test/commands/command/script/import/Makefile
  packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/Makefile
  packages/Python/lldbsuite/test/commands/disassemble/basic/Makefile
  packages/Python/lldbsuite/test/commands/expression/anonymous-struct/Makefile
  packages/Python/lldbsuite/test/commands/expression/argument_passing_restrictions/Makefile
  packages/Python/lldbsuite/test/commands/expression/call-function/Makefile
  packages/Python/lldbsuite/test/commands/expression/call-overridden-method/Makefile
  packages/Python/lldbsuite/test/commands/expression/call-restarts/Makefile
  packages/Python/lldbsuite/test/commands/expression/call-throws/Makefile
  packages/Python/lldbsuite/test/commands/expression/cast_int_to_anonymous_enum/Makefile
  packages/Python/lldbsuite/test/commands/expression/char/Makefile
  packages/Python/lldbsuite/test/commands/expression/class_template_specialization_empty_pack/Makefile
  packages/Python/lldbsuite/test/commands/expression/completion-crash-incomplete-record/Makefile
  packages/Python/lldbsuite/test/commands/expression/completion-crash-lambda/Makefile
  packages/Python/lldbsuite/test/commands/expression/completion-crash1/Makefile
  packages/Python/lldbsuite/test/commands/expression/completion-crash2/Makefile
  packages/Python/lldbsuite/test/commands/expression/completion/Makefile
  packages/Python/lldbsuite/test/commands/expression/context-object-objc/Makefile
  packages/Python/lldbsuite/test/commands/expression/context-object/Makefile
  packages/Python/lldbsuite/test/commands/expression/dollar-in-variable/Makefile
  packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/Makefile
  packages/Python/lldbsuite/test/commands/expression/entry-bp/Makefile
  packages/Python/lldbsuite/test/commands/expression/expr-in-syscall/Makefile
  packages/Python/lldbsuite/test/commands/expression/fixits/Makefile
  packages/Python/lldbsuite/test/commands/expression/formatters/Makefile
  packages/Python/lldbsuite/test/commands/expression/function_template_specialization_temp_args/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/basic/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/conflicts/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/deque-basic/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/deque-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/forward_list-basic/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/forward_list-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/list-basic/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/list-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/no-std-module/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/queue/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/shared_ptr-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/shared_ptr/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/stack/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/sysroot/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/unique_ptr-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/unique_ptr/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/vector-basic/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/vector-bool/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/vector-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/vector-of-vectors/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/weak_ptr-dbg-info-content/Makefile
  packages/Python/lldbsuite/test/commands/expression/import-std-module/weak_ptr/Makefile
  packages/Python/lldbsuite/test/commands/expression/import_builtin_fileid/Makefile
  packages/Python/lldbsuite/test/commands/expression/inline-namespace/Makefile
  packages/Python/lldbsuite/test/commands/expression/ir-interpreter-phi-nodes/Makefile
  packages/Python/lldbsuite/test/commands/expression/ir-interpreter/Makefile
  packages/Python/lldbsuite/test/commands/expression/issue_11588/Makefile
  packages/Python/lldbsuite/test/commands/expression/macros/Makefile
  packages/Python/lldbsuite/test/commands/expression/multiline-completion/Makefile
  packages/Python/lldbsuite/test/commands/expression/namespace_local_var_same_name_cpp_and_c/Makefile
  packages/Python/lldbsuite/test/commands/expression/namespace_local_var_same_name_obj_c/Makefile
  packages/Python/lldbsuite/test/commands/expression/no-deadlock/Makefile
  packages/Python/lldbsuite/test/commands/expression/options/Makefile
  packages/Python/lldbsuite/test/commands/expression/persist_objc_pointeetype/Makefile
  packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/Makefile
  packages/Python/lldbsuite/test/commands/expression/persistent_types/Makefile
  packages/Python/lldbsuite/test/commands/expression/persistent_variables/Makefile
  packages/Python/lldbsuite/test/commands/expression/po_verbosity/Makefile
  packages/Python/lldbsuite/test/commands/expression/pr35310/Makefile
  packages/Python/lldbsuite/test/commands/expression/radar_8638051/Makefile
  packages/Python/lldbsuite/test/commands/expression/radar_9531204/Makefile
  packages/Python/lldbsuite/test/commands/expression/radar_9673664/Makefile
  packages/Python/lldbsuite/test/commands/expression/rdar42038760/Makefile
  packages/Python/lldbsuite/test/commands/expression/rdar44436068/Makefile
  packages/Python/lldbsuite/test/commands/expression/save_jit_objects/Makefile
  packages/Python/lldbsuite/test/commands/expression/scoped_enums/Makefile
  packages/Python/lldbsuite/test/commands/expression/test/Makefile
  packages/Python/lldbsuite/test/commands/expression/timeout/Makefile
  packages/Python/lldbsuite/test/commands/expression/top-level/Makefile
  packages/Python/lldbsuite/test/commands/expression/top-level/dummy.mk
  packages/Python/lldbsuite/test/commands/expression/two-files/Makefile
  packages/Python/lldbsuite/test/commands/expression/unicode-in-variable/Makefile
  packages/Python/lldbsuite/test/commands/expression/unwind_expression/Makefile
  packages/Python/lldbsuite/test/commands/expression/vector_of_enums/Makefile
  packages/Python/lldbsuite/test/commands/expression/weak_symbols/Makefile
  packages/Python/lldbsuite/test/commands/expression/xvalue/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/array/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/bad-reference/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/complicated-expression/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/dereference-argument/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/dereference-function-return/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/dereference-this/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/inheritance/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/local-variable/Makefile
  packages/Python/lldbsuite/test/commands/frame/diagnose/virtual-method-call/Makefile
  packages/Python/lldbsuite/test/commands/frame/language/Makefile
  packages/Python/lldbsuite/test/commands/frame/recognizer/Makefile
  packages/Python/lldbsuite/test/commands/frame/var-scope/Makefile
  packages/Python/lldbsuite/test/commands/frame/var/Makefile
  packages/Python/lldbsuite/test/commands/gui/basic/Makefile
  packages/Python/lldbsuite/test/commands/log/basic/Makefile
  packages/Python/lldbsuite/test/commands/process/attach-resume/Makefile
  packages/Python/lldbsuite/test/commands/process/attach/Makefile
  packages/Python/lldbsuite/test/commands/process/attach/attach_denied/Makefile
  packages/Python/lldbsuite/test/commands/process/launch-with-shellexpand/Makefile
  packages/Python/lldbsuite/test/commands/process/launch/Makefile
  packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/Makefile
  packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_bound_violation/Makefile
  packages/Python/lldbsuite/test/commands/register/register/register_command/Makefile
  packages/Python/lldbsuite/test/commands/settings/Makefile
  packages/Python/lldbsuite/test/commands/settings/quoting/Makefile
  packages/Python/lldbsuite/test/commands/source/info/Makefile
  packages/Python/lldbsuite/test/commands/statistics/basic/Makefile
  packages/Python/lldbsuite/test/commands/target/basic/Makefile
  packages/Python/lldbsuite/test/commands/target/create-deps/Makefile
  packages/Python/lldbsuite/test/commands/target/create-deps/a.mk
  packages/Python/lldbsuite/test/commands/target/create-no-such-arch/Makefile
  packages/Python/lldbsuite/test/commands/target/stop-hooks/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/hello_watchlocation/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/hello_watchpoint/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/multi_watchpoint_slots/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/multiple_hits/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/multiple_threads/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/step_over_watchpoint/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/variable_out_of_scope/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_on_vectors/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_set_command/Makefile
  packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_size/Makefile
  packages/Python/lldbsuite/test/driver/batch_mode/Makefile
  packages/Python/lldbsuite/test/functionalities/archives/Makefile
  packages/Python/lldbsuite/test/functionalities/asan/Makefile
  packages/Python/lldbsuite/test/functionalities/avoids-fd-leak/Makefile
  packages/Python/lldbsuite/test/functionalities/completion/Makefile
  packages/Python/lldbsuite/test/functionalities/conditional_break/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/basic/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/exact_match/activity-chain/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/exact_match/activity/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/exact_match/category/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/exact_match/message/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/exact_match/subsystem/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/regex/activity-chain/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/regex/activity/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/regex/category/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/regex/message/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/filter/regex/subsystem/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/format/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/source/debug/Makefile
  packages/Python/lldbsuite/test/functionalities/darwin_log/source/info/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/boolreference/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/compactvectors/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-advanced/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-categories/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-cpp/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-disabling/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-enum-format/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-globals/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-named-summaries/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/nsindexpath/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/nsstring/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-proper-plurals/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-ptr-to-array/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-python-synth/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-script/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-smart-array/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/bitset/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/forward_list/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/iterator/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/loop/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/map/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multimap/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multiset/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/queue/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/set/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vector/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vbool/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synth/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synthtype/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synthval/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/format-propagation/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/frameformat_smallstruct/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/hexcaps/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/language_category_updates/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/nsarraysynth/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/nsdictionarysynth/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/nssetsynth/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/ostypeformatting/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/parray/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/poarray/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/ptr_ref_typedef/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/refpointer-recursion/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/setvaluefromcstring/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/summary-string-onfail/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/synthcapping/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/synthupdate/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_script/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/typedef_array/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/user-format-vs-summary/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/var-in-aggregate-misuse/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/varscript_formatting/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/vector-types/Makefile
  packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile
  packages/Python/lldbsuite/test/functionalities/deleted-executable/Makefile
  packages/Python/lldbsuite/test/functionalities/dynamic_value_child_count/Makefile
  packages/Python/lldbsuite/test/functionalities/exec/Makefile
  packages/Python/lldbsuite/test/functionalities/exec/secondprog.mk
  packages/Python/lldbsuite/test/functionalities/fat_archives/Makefile
  packages/Python/lldbsuite/test/functionalities/inferior-assert/Makefile
  packages/Python/lldbsuite/test/functionalities/inferior-changed/Makefile
  (306 more files...)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67083.218383.patch
Type: text/x-patch
Size: 256008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190902/a84bcf57/attachment-0001.bin>