[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 2 02:42:01 PDT 2019


labath created this revision.
labath added reviewers: amccarth, rnk, markmentovai.

This patch makes it possible to unwind via breakpad STACK WIN records.
It is "basic" because two important features are missing:

- support for the .raSearch keyword
- support for multiple STACK WIN records within a single function

Right now, we just reject the .raSearch records, and always pick the
first record for the whole function
SymbolFileBreakpad, and so I think it can serve as a good example of
what is needed of the symbol file and unwinding machinery to make this
work.

However, it is already useful for unwinding in some situations, and it
sets up the general framework for the parsing of these kinds of records,
which reduces the size of the followup patches implementing the two
other components.


https://reviews.llvm.org/D67067

Files:
  lit/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.syms
  lit/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.yaml
  lit/SymbolFile/Breakpad/unwind-via-stack-win.test
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67067.218316.patch
Type: text/x-patch
Size: 18657 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190902/2e44bc86/attachment.bin>


More information about the lldb-commits mailing list